Commit graph

19 commits

Author SHA1 Message Date
f8113c22ab Merge branch 'atomaka/feature/integration-testing' into 'master'
Add some basic integration testing

Rushed but it'll work for now

See merge request !9
2015-07-14 13:54:10 -04:00
7975ec2012 Add some basic integration testing
Rushed but it'll work for now
2015-07-14 13:51:15 -04:00
2cac3d9f1c Merge branch 'atomaka/feature/subcreddit' into 'master'
Add subcreddits

Reddit has subreddits. We have subcreddits.  Get it?  Because we're subcreddit.

See merge request !8
2015-07-13 17:04:45 -04:00
d3dd0ff848 Add the subcreddit MVC
Notes on closing subcreddit:

This doesn't seem great.  Would be slightly better if closed could be referenced
as true or false instead of '0' or '1' in the model.  Testing this is a bit
messy, but Tiemcop makes it a bit better.

Notes on subcreddit validations:

This is still not ideal.  For starters, from
http://guides.rubyonrails.org/active_record_validations.html:

"Note that some databases are configured to perform case-insensitive searches
anyway."

It also seems difficult to validate fields that are set in before_save since
validations occur before callbacks.  Revisit this (perhaps friendly_id wll save
us).
2015-07-13 17:01:12 -04:00
527dc493c6 Merge branch 'atomaka/refactor/downcase-test-fix' into 'master'
Slight organization cleanup in users tests

Downcasing of the email address actually happens with valid data.

See merge request !7
2015-07-13 14:57:07 -04:00
da37a057cb Downcasing emails actually happens with valid data 2015-07-13 14:53:44 -04:00
dd69e9a89b Merge branch 'atomaka/feature/flash-messages' into 'master'
Add flash notices

Add ability to serve flash messages and add them for sign in, sign out, and sign up.

See merge request !6
2015-07-10 16:46:31 -04:00
1abbdbac12 Add flash notices for sign in, sign out, sign up 2015-07-10 16:21:59 -04:00
f91390baf6 Merge branch 'atomaka/feature/sessions' into 'master'
Add user sessions

Although rails provides built-in user sessions, this allows us to add additional fields to the session model. For example, we can now track the user agent and IP address of all sessions associated with a user.  Long term, this allows us to do neat things like session revocation (by both user and admin) and sudo mode.

See merge request !5
2015-07-10 14:59:45 -04:00
3308cfc1c1 Add user sessions 2015-07-10 14:33:39 -04:00
1bda41e83a Merge branch 'atomaka/feature/testing-metrics' into 'master'
Add metrics for testing / style / best practices

Bad rebase in PR !2? perhaps.  This readds some of the stuff that was missing.

See merge request !4
2015-07-10 00:28:33 -04:00
6708b4a501 Add metrics for testing / style / best practices 2015-07-10 00:27:23 -04:00
29600b12a3 Merge branch 'atomaka/feature/layout' into 'master'
Layout updates

We basically are reddit now

See merge request !3
2015-07-09 23:50:22 -04:00
790cb26f2a We basically are reddit now 2015-07-09 23:47:34 -04:00
80af796096 Merge branch 'atomaka/feature/users' into 'master'
Add user creation

Adds simple creation of users that have a username, password, and an email.  The password is managed by Rail's `has_secure_password`.

See merge request !2
2015-07-09 16:39:04 -04:00
8344498740 Add user creation 2015-07-09 16:31:41 -04:00
6fee16e22a Merge branch 'atomaka/feature/testing-development-setup' into 'master'
Initial Gems and Setup

Install necessary gems and set them up appropriately.  Mainly testing environment and design type stuff.

See merge request !1
2015-07-08 15:06:03 -04:00
0c0c128f5e Development and testing setup 2015-07-08 14:51:49 -04:00
b6ec589f33 Initial commit 2015-07-08 10:24:41 -04:00