Cleanup a few N+1

app/controllers/cards_controller.rb

@@ -2,7 +2,7 @@ class CardsController < ApplicationController
   before_action :set_card, only: [:show, :edit, :update, :destroy]
 
   def index
-    @cards = Card.all
+    @cards = Card.includes(:character).all
   end
 
   def show
@@ -42,7 +42,7 @@ class CardsController < ApplicationController
   private
 
   def card_params
-    params.require(:card).permit(:prefix, :character_id, :rarity_id, :type_id,
+    params.require(:card).permit(:title, :character_id, :rarity_id, :type_id,
                                  :leader_skill_id, :passive_skill_id,
                                  :super_attack_id, :dokkan_id, :gameid,
                                  :awaken_type_id, :dokkan_id, link_ids: [])

app/models/super_attack.rb

@@ -1,4 +1,8 @@
 class SuperAttack < ActiveRecord::Base
   validates :name, presence: true
   validates :description, presence: true
+
+  def full
+    "#{name} - #{description}"
+  end
 end

app/views/cards/_form.html.slim

@@ -21,10 +21,10 @@
         = f.association :passive_skill
     .row
       .col-md-6
-        = f.association :super_attack
+        = f.association :super_attack, label_method: :full
     .row
       .col-md-6
-        = f.association :dokkan_card, label_method: :full_name
+        = f.association :dokkan_card, collection: Card.includes(:character).all, label_method: :full_name
     .row
       .col-md-12
         = f.label :links