atomaka/budget
1
0
Fork 0
Code Issues 1 Pull requests 3 Activity Actions

Require authentication for most endpoints (#29)

Browse source 
Reviewed-on: #29
This commit is contained in:
Andrew Tomaka 2024-09-08 21:07:51 -04:00
parent 0f95034e8e
commit c64550785e
15 changed files with 84 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

1
app/controllers/application_controller.rb
View file

@ -1,3 +1,4 @@
class ApplicationController < ActionController::Base
include Authenticatable
include Authorizable
end

37
app/controllers/concerns/authorizable.rb Normal file
View file

@ -0,0 +1,37 @@
module Authorizable
extend ActiveSupport::Concern
included do
before_action :require_registered_user
end
class_methods do
def allow_unregistered_user(**args)
skip_before_action :require_registered_user, **args
end
def require_unregistered_user(**args)
skip_before_action :require_registered_user, **args
before_action :require_unregistered_user, **args
end
end
private
def require_registered_user
Current.user.registered? || redirect_to_sign_in
end
def require_unregistered_user
Current.user.unregistered? || redirect_to_dashboard
end
def redirect_to_sign_in
session[:return_url] = request.url
redirect_to new_session_url, alert: "You must be logged in to continue."
end
def redirect_to_dashboard
redirect_to root_url, alert: "You are already logged in."
end
end

10
app/controllers/sessions_controller.rb
View file

@ -1,4 +1,5 @@
class SessionsController < ApplicationController
require_unregistered_user only: %i[new create]
# GET /sessions/new
def new
@session = Session.new
@ -11,9 +12,8 @@ class SessionsController < ApplicationController
respond_to do |format|
if @session.save
session[:current_user_id] = @session.user_id
Rails.logger.info("ID: #{@session.user_id}")
format.html { redirect_to root_url, notice: "Session was successfully created." }
format.html { redirect_to redirect_url, notice: "Session was successfully created." }
format.json { render :show, status: :created, location: @session }
else
format.html { render :new, status: :unprocessable_entity, alert: @session.errors }
@ -27,12 +27,16 @@ class SessionsController < ApplicationController
session[:current_user_id] = nil
respond_to do |format|
format.html { redirect_to root_url, notice: "Session was successfully destroyed." }
format.html { redirect_to new_session_url, notice: "Session was successfully destroyed." }
format.json { head :no_content }
end
end
private
def redirect_url
session.delete(:return_url) || root_url
end
# Only allow a list of trusted parameters through.
def session_params
params.require(:session).permit(:email, :password)

9
app/controllers/users_controller.rb
View file

@ -1,4 +1,6 @@
class UsersController < ApplicationController
require_unregistered_user only: %i[new create]
before_action :set_user, only: %i[ show edit update destroy ]
# GET /users or /users.json
@ -25,6 +27,9 @@ class UsersController < ApplicationController
respond_to do |format|
if @user.save
@session = Session.new(session_params).save
session[:current_user_id] = @session.user_id
format.html { redirect_to user_url(@user), notice: "User was successfully created." }
format.json { render :show, status: :created, location: @user }
else
@ -67,4 +72,8 @@ class UsersController < ApplicationController
def user_params
params.require(:user).permit(:email, :password, :password_confirmation)
end
def session_params
user_params.slice(:email, :password)
end
end

2
app/models/guest_user.rb
View file

@ -1,3 +1,5 @@
class GuestUser
def registered? = false
def unregistered? = true
end

2
app/models/user.rb
View file

@ -2,4 +2,6 @@ class User < ApplicationRecord
has_secure_password
def registered? = true
def unregistered? = false
end

11
app/views/layouts/application.html.erb
View file

@ -14,14 +14,15 @@
<body>
<nav class="w-100 p-6 bg-gray-900 flex items-center justify-between flex-wrap">
<ul class="flex">
<li class="mr-6"><%= link_to "Dashboard", root_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Expenses", expenses_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Credit Card Bills", credit_card_bills_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Incomes", incomes_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Members", members_path, class: "text-white" %></li>
<% if Current.user.registered? %>
<li class="mr-6"><%= link_to "Dashboard", root_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Expenses", expenses_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Credit Card Bills", credit_card_bills_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Incomes", incomes_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Members", members_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Log out", session_path, data: {turbo_method: :delete}, class: "text-white" %></li>
<% else %>
<li class="mr-6"><%= link_to "Sign up", new_user_path, class: "text-white" %></li>
<li class="mr-6"><%= link_to "Log in", new_session_path, class: "text-white" %></li>
<% end %>
</ul>